comphead commented on code in PR #22813:
URL: https://github.com/apache/datafusion/pull/22813#discussion_r3381846307
##########
datafusion/spark/src/function/math/round.rs:
##########
@@ -652,3 +678,76 @@ fn spark_round(args: &[ColumnarValue], enable_ansi_mode:
bool) -> Result<Columna
},
}
}
+
+#[cfg(test)]
Review Comment:
SLT tests should be enough.
We keep rust tests for SQL functions only if SLT coverage is not sufficient
and SLT constraints full test coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
