tshauck commented on code in PR #11787:
URL: https://github.com/apache/datafusion/pull/11787#discussion_r1702393553
##########
datafusion/functions/src/string/starts_with.rs:
##########
@@ -53,16 +76,18 @@ impl Default for StartsWithFunc {
impl StartsWithFunc {
pub fn new() -> Self {
use DataType::*;
+
+ let string_types = vec![Utf8, LargeUtf8, Utf8View];
+ let mut type_signatures = vec![];
+
+ for left in &string_types {
Review Comment:
I think it needed this update in the argument coercion logic... before this
even with Utf8View being preferred in the signature it wasn't recognized in the
type to/from statement:
https://github.com/apache/datafusion/pull/11787/files#diff-6e1fb265597317a8256c60670ff3ea7be6896b2df1199a40ca79419ce29b4ce3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
