dharanad commented on code in PR #11787:
URL: https://github.com/apache/datafusion/pull/11787#discussion_r1702437238
##########
datafusion/functions/src/string/starts_with.rs:
##########
@@ -81,18 +75,73 @@ impl ScalarUDFImpl for StartsWithFunc {
}
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
- use DataType::*;
-
- Ok(Boolean)
+ Ok(DataType::Boolean)
}
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
match args[0].data_type() {
- DataType::Utf8 => make_scalar_function(starts_with::<i32>,
vec![])(args),
- DataType::LargeUtf8 => {
- return make_scalar_function(starts_with::<i64>, vec![])(args);
+ DataType::Utf8View | DataType::Utf8 | DataType::LargeUtf8 => {
+ make_scalar_function(starts_with, vec![])(args)
}
- _ => internal_err!("Unsupported data type"),
+ _ => internal_err!("Unsupported data types for starts_with")?,
Review Comment:
How about adding info about unsupported data type in error message ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
