alamb commented on PR #11787: URL: https://github.com/apache/datafusion/pull/11787#issuecomment-2266670535
> Thank you for this nice work, it looks good to me. > > Given this PR can become an example for supporting `StringView` for remaining string functions, I suggest also: > > 1. Add more sqllogictests, since they're easier to understand and follow. > 2. In sqllogictest end-to-end tests, include more edge cases like empty strings, mismatched argument types like `starts_with(utf8_col, utf8view_col)`, this way we can encourage other contibutors to follow the pattern and write better tests for the remaining functions. I think this is a great suggestion @2010YOUY01 -- I can help with this too Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest Ideally you should be able to extend `string_view.slt` perhaps in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
