davidlghellin commented on PR #20928: URL: https://github.com/apache/datafusion/pull/20928#issuecomment-4673065772
@Jefffrey Thanks for the thorough review — all four addressed. While auditing this file I noticed there's room for a `simplify()` impl covering the literal cases: - `concat_ws(NULL_literal, …)` → `NULL` - `concat_ws(sep_literal)` (only separator) → `''` - `concat_ws(sep, single_utf8_literal)` → that literal It would let the planner short-circuit at plan time instead of dispatching per batch. Would you prefer I add it to this PR, or open a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
