alamb commented on code in PR #22915:
URL: https://github.com/apache/datafusion/pull/22915#discussion_r3398337828
##########
datafusion/optimizer/src/optimize_projections/mod.rs:
##########
@@ -764,12 +780,12 @@ fn split_join_requirements(
// The mark column is synthetic (produced by the join itself),
// so discard it and route only to the left child.
let (left_indices, _mark) = indices.split_off(left_len);
- (left_indices, RequiredIndices::new())
+ (left_indices, RequiredIndices::new().append(&[0]))
Review Comment:
Looks like this code was added in
https://github.com/apache/datafusion/pull/21265 from @buraksenn
@buraksenn do you have some time to help review this proposed change?
I think it would help if we can also document in comments why `[0]` is being
appended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
