HairstonE commented on code in PR #22915:
URL: https://github.com/apache/datafusion/pull/22915#discussion_r3403754341
##########
datafusion/optimizer/src/optimize_projections/mod.rs:
##########
@@ -764,12 +780,12 @@ fn split_join_requirements(
// The mark column is synthetic (produced by the join itself),
// so discard it and route only to the left child.
let (left_indices, _mark) = indices.split_off(left_len);
- (left_indices, RequiredIndices::new())
+ (left_indices, RequiredIndices::new().append(&[0]))
Review Comment:
I traced the error there and that change guaranteed the column would be
non-empty. Typing that out makes me think I shouldn't assume they are empty? So
I should only deal with the empty case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
