Re: [PR] Replace `display_name` with `schema_name` [datafusion]

[via GitHub]

jayzhan211 commented on code in PR #11797:
URL: https://github.com/apache/datafusion/pull/11797#discussion_r1703143988


##########
datafusion/sql/src/utils.rs:
##########
@@ -469,16 +469,16 @@ mod tests {
         assert_eq!(
             transformed_exprs,
             vec![
-                col("unnest(struct_col).field1"),
-                col("unnest(struct_col).field2"),
+                col("UNNEST(struct_col).field1"),

Review Comment:
   Uppercase it to be consistent like other expressions



##########
datafusion/sql/src/utils.rs:
##########
@@ -469,16 +469,16 @@ mod tests {
         assert_eq!(
             transformed_exprs,
             vec![
-                col("unnest(struct_col).field1"),
-                col("unnest(struct_col).field2"),
+                col("UNNEST(struct_col).field1"),

Review Comment:
   Uppercase it to be consistent with other expressions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org