jayzhan211 commented on code in PR #11797:
URL: https://github.com/apache/datafusion/pull/11797#discussion_r1706717034
##########
datafusion/expr/src/udf.rs:
##########
@@ -345,12 +351,22 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
fn name(&self) -> &str;
/// Returns the user-defined display name of the UDF given the arguments
- ///
fn display_name(&self, args: &[Expr]) -> Result<String> {
- let names: Vec<String> =
args.iter().map(create_name).collect::<Result<_>>()?;
+ let names: Vec<String> =
args.iter().map(ToString::to_string).collect();
+ // TODO: join with ", " to standardize the formatting of Vec<Expr>,
<https://github.com/apache/datafusion/issues/10364>
Ok(format!("{}({})", self.name(), names.join(",")))
}
+ /// Returns the user-defined schema name of the UDF given the arguments
Review Comment:
It seems I need another `SchemaFunctionDisplay` for replacing String with
impl Display in UDFImpl. I would like to hold on to the change for function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
