jayzhan211 commented on code in PR #11797:
URL: https://github.com/apache/datafusion/pull/11797#discussion_r1706333390
##########
datafusion/expr/src/expr.rs:
##########
@@ -983,10 +983,290 @@ impl PartialOrd for Expr {
}
impl Expr {
- /// Returns the name of this expression as it should appear in a schema.
This name
- /// will not include any CAST expressions.
- pub fn display_name(&self) -> Result<String> {
- create_name(self)
+ /// Returns the name for schema / field that is different from Display
+ /// Most of the expressions are the same as Display
+ /// Those are the main difference
+ /// 1. Alias, where excludes expression
+ /// 2. Cast / TryCast, where takes expression only
+ pub fn schema_name(&self) -> Result<String> {
Review Comment:
This looks cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
