tshauck commented on PR #11787: URL: https://github.com/apache/datafusion/pull/11787#issuecomment-2267687429
I added some additional tests, and made one change to keep `NULL` literals from casting. With the tests, things look good generally, though `STARTS_WITH(column1_utf8, column2_utf8view)` is a bit unfortunate as casts the first column to a utf8view. It's probably not a common use case, but I'd guess cast plus string compare (even with view) is slower than casting a scalar? Perhaps if this looks ok enough I can add a benchmark for `starts_with` as follow up for testing. Or if there's enough concern I'd be happy to do that leg work as part of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
