dinmukhamedm commented on code in PR #2385:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2385#discussion_r3448201051
##########
tests/sqlparser_clickhouse.rs:
##########
@@ -1846,6 +1846,44 @@ fn parse_inner_array_join() {
}
}
+#[test]
+fn parse_in_unparenthesized_placeholder() {
+ // ClickHouse `{name:Type}` query-parameter placeholder as the IN RHS,
without parens.
+ match clickhouse().expr_parses_to("x IN {ids:Array(UInt64)}", "x IN ({ids:
Array(UInt64)})") {
Review Comment:
would you like me to move the tests to the common file?
Otherwise, I should have used the function `clickhouse()` at the bottom of
this file that only returns the clickhouse dialect. This will be more
consistent with the rest of the tests in this file.
Let me know which option you prefer, and I can adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
