dinmukhamedm commented on code in PR #2385:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2385#discussion_r3493253305
##########
tests/sqlparser_common.rs:
##########
@@ -2375,15 +2375,45 @@ fn parse_in_unnest() {
#[test]
fn parse_in_error() {
- // <expr> IN <expr> is no valid
+ // <expr> IN <expr> is no valid, except in dialects that accept an
+ // unparenthesized expression as the IN right-hand side (e.g. ClickHouse).
let sql = "SELECT * FROM customers WHERE segment in segment";
- let res = parse_sql_statements(sql);
+ let res =
+ all_dialects_except(|d|
d.supports_in_unparenthesized_expr()).parse_sql_statements(sql);
assert_eq!(
ParserError::ParserError("Expected: (, found: segment".to_string()),
res.unwrap_err()
);
}
+#[test]
+fn parse_in_unparenthesized_expr() {
+ // Dialects supporting an unparenthesized IN right-hand side wrap a bare
expression
+ // into a single-element list (e.g. `x IN 'a'` -> `x IN ('a')`).
+ let dialects = all_dialects_where(|d|
d.supports_in_unparenthesized_expr());
+ dialects.expr_parses_to("x IN 'a'", "x IN ('a')");
+
+ // The branch must not fire when the next token is `(` (regressions).
+ dialects.verified_expr("x IN (1, 2, 3)");
+ dialects.verified_stmt("SELECT * FROM t WHERE x IN (SELECT y FROM u)");
+}
+
+#[test]
+fn parse_in_unparenthesized_dictionary_placeholder() {
+ // The `{name:Type}` placeholder form additionally requires dictionary
syntax.
+ let dialects = all_dialects_where(|d| {
+ d.supports_in_unparenthesized_expr() && d.supports_dictionary_syntax()
+ });
+ dialects.expr_parses_to("x IN {ids:Array(UInt64)}", "x IN ({ids:
Array(UInt64)})");
+ dialects.expr_parses_to(
+ "x NOT IN {ids:Array(UInt64)}",
+ "x NOT IN ({ids: Array(UInt64)})",
+ );
+ dialects.verified_expr("x IN ({ids: Array(UInt64)})");
+ // Precedence: the trailing `AND` is not swallowed.
+ dialects.verified_expr("x IN ({p: Array(UInt64)}) AND y = 1");
+}
Review Comment:
no, good catch. This was because I started with dict, and then realized
clickhouse allows for everything else unparenthesized. Removed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
