github-actions[bot] commented on PR #23148: URL: https://github.com/apache/datafusion/pull/23148#issuecomment-4787355284
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v54.0.0 (current) Built [ 28.821s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.077s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 27.046s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.076s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.410s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 58.533s] datafusion-expr Building datafusion-ffi v54.0.0 (current) Built [ 60.050s] (current) Parsing datafusion-ffi v54.0.0 (current) Parsed [ 0.062s] (current) Building datafusion-ffi v54.0.0 (baseline) Built [ 62.472s] (baseline) Parsing datafusion-ffi v54.0.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.273s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron Failed in: field FFI_ScalarUDF.is_strict in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:87 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_ScalarUDF.coerce_types moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:93 FFI_ScalarUDF.placement moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:101 FFI_ScalarUDF.clone moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:108 FFI_ScalarUDF.release moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:111 FFI_ScalarUDF.private_data moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:115 FFI_ScalarUDF.library_marker_id moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:120 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 124.223s] datafusion-ffi Building datafusion-functions v54.0.0 (current) Built [ 31.295s] (current) Parsing datafusion-functions v54.0.0 (current) Parsed [ 0.087s] (current) Building datafusion-functions v54.0.0 (baseline) Built [ 31.143s] (baseline) Parsing datafusion-functions v54.0.0 (baseline) Parsed [ 0.090s] (baseline) Checking datafusion-functions v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.413s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 64.186s] datafusion-functions Building datafusion-optimizer v54.0.0 (current) Built [ 27.793s] (current) Parsing datafusion-optimizer v54.0.0 (current) Parsed [ 0.030s] (current) Building datafusion-optimizer v54.0.0 (baseline) Built [ 27.235s] (baseline) Parsing datafusion-optimizer v54.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.172s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 56.044s] datafusion-optimizer Building datafusion-sqllogictest v54.0.0 (current) Built [ 178.020s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 178.296s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.092s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 358.853s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
