andygrove commented on code in PR #4683:
URL: https://github.com/apache/datafusion-comet/pull/4683#discussion_r3475080824
##########
spark/src/test/scala/org/apache/comet/parquet/CometParquetWriterSuite.scala:
##########
@@ -37,6 +38,27 @@ class CometParquetWriterSuite extends CometTestBase {
import testImplicits._
+ test("partitioned write with empty string partition value") {
+ withTempPath { path =>
+ Seq(("", 1), ("a", 2))
+ .toDF("part", "value")
+ .write
Review Comment:
Could you add an assertion to check that the write is executed by Comet?
From reading the PR description, my understanding is that we expect
`empty2null` to be called during the write operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
