andygrove commented on code in PR #4693:
URL: https://github.com/apache/datafusion-comet/pull/4693#discussion_r3475026778
##########
spark/src/main/scala/org/apache/comet/serde/datetime.scala:
##########
@@ -711,9 +777,10 @@ object CometDateFormat extends
CometExpressionSerde[DateFormatClass] {
case _ => None
}
- val canUseNative = nativeFormat.isDefined && {
- isUtc || CometConf.isExprAllowIncompat(getExprConfigName(expr))
- }
+ val canUseNative = nativeFormat.isDefined &&
+ !expr.children.exists(c => hasNonDefaultStringCollation(c.dataType)) && {
Review Comment:
This seems incorrect, or is at least inconsistent with other date/time
functions. It seems there is no way to enable the native incompatible
expression now due to the `hasNonDefaultStringCollation` check introduced here?
PR looks good other than this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
