peterxcli opened a new pull request, #4745: URL: https://github.com/apache/datafusion-comet/pull/4745
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #4673. ## Rationale for this change This finishes the misc scalar serde follow-up for #4673. These serdes still had static support decisions in `convert`, even though the dispatcher expects those decisions to come from `getSupportLevel`. Binding-dependent failures and child fallback rollups still stay in `convert`. ## What changes are included in this PR? Move static support checks into `getSupportLevel` for: - `AttributeReference`: unsupported data types. - `FromUnixTime`: unsupported native datetime format when the incompatible native path is enabled, while keeping the default codegen-dispatch path unchanged. - `KnownFloatingPointNormalized`: unsupported wrapped child data types. The remaining `withFallbackReason` calls in these files are for child conversion or binding-dependent failures. ## How are these changes tested? Added focused coverage in `CometExpressionSuite` for the misc scalar serde `getSupportLevel` decisions. Also ran: `./mvnw test -Pspark-3.5 -Pscala-2.12 -Dtest=none -Dsuites="org.apache.comet.CometExpressionSuite misc scalar serdes report static unsupported cases via getSupportLevel" -Dscalastyle.skip=true` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
