andygrove commented on code in PR #4745:
URL: https://github.com/apache/datafusion-comet/pull/4745#discussion_r3493145853
##########
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##########
@@ -22,19 +22,28 @@ package org.apache.comet.serde
import org.apache.spark.sql.catalyst.expressions.{Attribute, FromUnixTime,
Literal}
import org.apache.spark.sql.catalyst.util.TimestampFormatter
+import org.apache.comet.CometConf
import org.apache.comet.CometSparkSessionExtensions.withFallbackReason
import org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal,
optExprWithFallbackReason, scalarFunctionExprToProto}
// TODO: DataFusion supports only -8334601211038 <= sec <= 8210266876799
// https://github.com/apache/datafusion/issues/16594
object CometFromUnixTime extends CometExpressionSerde[FromUnixTime] with
CodegenDispatchFallback {
+ private val unsupportedFormatReason = "Datetime pattern format is
unsupported"
Review Comment:
Could you implement `getUnsupportedReasons`, referencing
`unsupportedFormatReason` so that this gets generated into the docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
