Kevin-Li-2025 commented on PR #23066: URL: https://github.com/apache/datafusion/pull/23066#issuecomment-4833141590
Pushed f36a91010 to address the remaining sqlite sqllogictest failure. The failed CI run showed the dynamic filter threshold as `column1@0 > 3`, while the same focused test can produce `column1@0 > 4` locally. That matches the existing note in the test: the partial aggregate dynamic-filter update races with scan progress under parallel execution. I changed this assertion to keep checking the stable invariant (`DynamicFilter` is present, dynamic row-group pruning is eligible, and metrics are suppressed) while ignoring the volatile threshold value and file-group text. Local validation: - `cargo test -p datafusion-sqllogictest --test sqllogictests -- push_down_filter_regression --include-sqlite` - `cargo fmt --all -- --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
