github-actions[bot] commented on PR #23066: URL: https://github.com/apache/datafusion/pull/23066#issuecomment-4841771424
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 113.703s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.034s] (current) Building datafusion v54.0.0 (baseline) Built [ 106.880s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.686s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 222.991s] datafusion Building datafusion-execution v54.0.0 (current) Built [ 32.781s] (current) Parsing datafusion-execution v54.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-execution v54.0.0 (baseline) Built [ 32.415s] (baseline) Parsing datafusion-execution v54.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-execution v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.253s] 223 checks: 219 pass, 4 fail, 0 warn, 30 skip --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_missing.ron Failed in: variant DiskManagerMode::Custom, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/disk_manager.rs:135 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/module_missing.ron Failed in: mod datafusion_execution::spill_file, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron Failed in: struct datafusion_execution::disk_manager::FileSpillWriter, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/disk_manager.rs:415 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_missing.ron Failed in: trait datafusion_execution::spill_file::TempFileFactory, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:50 trait datafusion_execution::TempFileFactory, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:50 trait datafusion_execution::spill_file::SpillWriter, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:44 trait datafusion_execution::SpillWriter, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:44 trait datafusion_execution::spill_file::SpillFile, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:27 trait datafusion_execution::SpillFile, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d8eebbf84110e5554a883ba34b03a88eae3168ef/datafusion/execution/src/spill_file.rs:27 Summary semver requires new major version: 4 major and 0 minor checks failed Finished [ 66.969s] datafusion-execution Building datafusion-physical-plan v54.0.0 (current) Built [ 40.161s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.138s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 39.830s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.138s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.680s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 82.176s] datafusion-physical-plan Building datafusion-sqllogictest v54.0.0 (current) Built [ 185.460s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 175.228s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.098s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 363.737s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
