gene-bordegaray commented on code in PR #23239:
URL: https://github.com/apache/datafusion/pull/23239#discussion_r3501079760
##########
datafusion/physical-optimizer/src/sanity_checker.rs:
##########
@@ -162,11 +166,24 @@ pub fn check_plan_sanity(
}
}
- if !child
+ let child_satisfies_distribution = child
.output_partitioning()
.satisfaction(&dist_req, child_eq_props, true)
- .is_satisfied()
- {
+ .is_satisfied();
+ let range_satisfies_aggregate_distribution =
Review Comment:
Yes, want to hold off on doing general satisfaction until a few operators
are implemented privately to ensure we have the correct semantics API contracts
fleshed out a but more 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
