alamb commented on PR #23239: URL: https://github.com/apache/datafusion/pull/23239#issuecomment-4858636055
I agree with @2010YOUY01 -- the more SLT coverage we have, the better (otherwise we end up not testing that all the paths are correctly hooked up and we convince ourselves (or the LLMs convince us) that the code does what we want, when maybe it doesn't We already invested a bunch of time getting the SLT support for range partitioing in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/range_partitioning.slt so this should be a fairly simple addition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
