gene-bordegaray commented on code in PR #23239: URL: https://github.com/apache/datafusion/pull/23239#discussion_r3506573945
########## datafusion/sqllogictest/test_files/range_partitioning.slt: ########## @@ -29,18 +29,16 @@ set datafusion.explain.physical_plan_only = true; ########## # TEST 1: Aggregate on Range Partition Column # Scanning range_key preserves source Range partitioning metadata. -# Planning still inserts Hash repartitioning today; later optimizer PRs can -# use this baseline to show when the repartition is removed. +# Planning does not need Hash repartitioning because Range partitioning +# colocates rows with equal range_key values. ########## Review Comment: I have expanded the slt tests much more now 👍 THese are acting ad the main end to end coverage for the range behavior as they pass throughn all the optmizer rules. I left small smike and "speciific" cases to units -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
