jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706842419
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -31,20 +31,18 @@ use arrow::{
use arrow_schema::{Field, Schema};
use datafusion_common::{
- downcast_value, internal_err, not_impl_err, plan_err, DFSchema,
DataFusionError,
- ScalarValue,
+ downcast_value, internal_err, not_impl_err, plan_err, DataFusionError,
ScalarValue,
Review Comment:
Somes changes I prefer to leave it alone to make this PR smaller, for
example like the `Result` in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
