jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706869120
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -395,6 +379,8 @@ impl BuiltInWindowFunctionExpr for WindowUDFExpr {
}
}
+// TODO: Find a way to make clippy happy
+#[allow(clippy::needless_borrow)]
Review Comment:
```
error: this expression creates a reference which is immediately dereferenced
by the compiler
--> datafusion/physical-plan/src/windows/mod.rs:401:28
|
401 | Arc::clone(&expr),
| ^^^^^ help: change this to: `expr`
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
```
This is the clippy error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
