jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706858759
##########
datafusion/physical-expr-common/src/physical_expr.rs:
##########
@@ -193,33 +191,6 @@ pub fn with_new_children_if_necessary(
}
}
-/// Rewrites an expression according to new schema; i.e. changes the columns it
-/// refers to with the column at corresponding index in the new schema. Returns
-/// an error if the given schema has fewer columns than the original schema.
-/// Note that the resulting expression may not be valid if data types in the
-/// new schema is incompatible with expression nodes.
-pub fn with_new_schema(
Review Comment:
The best place we could move to is probably `expressions::mod`, it should be
in the same crate with `Column`, but I don't think there is much different, so
I keep it besides column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
