Michael-J-Ward opened a new pull request, #11878:
URL: https://github.com/apache/datafusion/pull/11878

   
   ## Which issue does this PR close?
   
   Closes #11877.
   
   ## Rationale for this change
   
   The UDAF `approx_percentile_cont` has a [third optional 
argument](https://datafusion.apache.org/user-guide/sql/aggregate_functions.html#approx-percentile-cont)
 that the [fluent 
api](https://docs.rs/datafusion/40.0.0/datafusion/functions_aggregate/approx_percentile_cont/fn.approx_percentile_cont.html)
 does not currently expose.
   
   This PR add the 3rd optional argument, consistent with how 
[array_slice](https://github.com/apache/datafusion/issues/10424) and 
[regexp_*](https://github.com/apache/datafusion/pull/10514) fluent APIs expose 
optional arguments.
   
   ## What changes are included in this PR?
   
   Add `centroids: Option<Expr>` to the fluent API.
   
   ## Are these changes tested?
   
   Yes.
   
   ## Are there any user-facing changes?
   
   Yes. Any user of the `approx_percentile_cont` fluent API will need to add 
`None` for the optional argument.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to