jayzhan211 commented on code in PR #11878:
URL: https://github.com/apache/datafusion/pull/11878#discussion_r1709392439
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -46,13 +46,21 @@ use datafusion_physical_expr_common::aggregate::tdigest::{
};
use
datafusion_physical_expr_common::utils::limited_convert_logical_expr_to_physical_expr_with_dfschema;
-make_udaf_expr_and_func!(
- ApproxPercentileCont,
- approx_percentile_cont,
- expression percentile,
- "Computes the approximate percentile continuous of a set of numbers",
- approx_percentile_cont_udaf
-);
+create_func!(ApproxPercentileCont, approx_percentile_cont_udaf);
+
+/// Computes the approximate percentile continuous of a set of numbers
+pub fn approx_percentile_cont(
+ expression: datafusion_expr::Expr,
+ percentile: datafusion_expr::Expr,
+ centroids: Option<datafusion_expr::Expr>,
+) -> datafusion_expr::Expr {
Review Comment:
nit: Avoid repeated import prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
