Michael-J-Ward commented on code in PR #11878:
URL: https://github.com/apache/datafusion/pull/11878#discussion_r1709524393


##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -394,6 +394,21 @@ async fn test_fn_approx_percentile_cont() -> Result<()> {
 
     assert_batches_eq!(expected, &batches);
 
+    // with number of centroids set
+    let expr = approx_percentile_cont(col("b"), lit(0.5), Some(lit(2)));

Review Comment:
   NOTE: I don't have SQL Server, so I did not verify that it produces this 
result.
   
   I chose a choice for `centroids` that produced a different result than the 
default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to