gene-bordegaray commented on code in PR #23189: URL: https://github.com/apache/datafusion/pull/23189#discussion_r3544046751
########## datafusion/datasource/src/file_scan_config/mod.rs: ########## Review Comment: The point I am making is we need to discuss this. We are claiming `Partitioning::Hash` on these while in reality we are not has partitioned we are actaully partitioned by the partition column values. This was the same situation which users faced when decalring `Partitioning::Range` as hash. This behavior was here before but we should discuss what this means going forward with this feature. Should we: - Introduce another variant of the `Partitioning` enum like `ValuePartitioned` (this would be much easier now that `Partitioning::Range` has really started to lay the ground work for doing this - Does this justify `Partitioning` becoming a trait of some type where users can implmenet their own custome partitioning types - Some other option I am not seeing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
