gene-bordegaray commented on code in PR #23189:
URL: https://github.com/apache/datafusion/pull/23189#discussion_r3544059228
##########
datafusion/catalog-listing/src/table.rs:
##########
@@ -628,6 +630,15 @@ impl TableProvider for ListingTable {
);
}
Some(output_partitioning)
+ } else if partitioned_by_file_group {
+ // Files are grouped by partition column values: declare Hash
+ // partitioning on those columns so the optimizer can skip hash
Review Comment:
The concern is not the comment itself but the actual behavior of this
feature is lying to DF. This claims a hash partitioning but in reality we are
not partitioned by the hash function at all. Let me know if you have questions
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
