jayshrivastava commented on code in PR #23189: URL: https://github.com/apache/datafusion/pull/23189#discussion_r3544133348
########## datafusion/datasource/src/file_scan_config/mod.rs: ########## Review Comment: > We are claiming Partitioning::Hash on these while in reality we are not has partitioned we are actaully partitioned by the partition column values. This was the same situation which users faced when decalring Partitioning::Range as hash. +1. This is exactly the pain I'm experiencing. It leads to correctness issues ex. dynamic filtering breaks if you are not hash partitioned but claim to be hash partitioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
