gabotechs commented on code in PR #23189:
URL: https://github.com/apache/datafusion/pull/23189#discussion_r3549906872
##########
datafusion/datasource/src/file_scan_config/mod.rs:
##########
Review Comment:
My first instinct would be to remove `Partitioning::Hash` in favor of (very
rought draft):
```rust
pub enum Partitioning {
...
#[deprecated]
Hash(Vec<Expr>),
Value {
expressions: Vec<Expr>, // Same as Partitioning::Hash
method: &'static str // The value partitioning method (e.g.,
"ahash(0,0,0,0)", "ahash(1,2,3,4)" ...)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
