github-actions[bot] commented on PR #23495: URL: https://github.com/apache/datafusion/pull/23495#issuecomment-4952225565
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.0.0 (current) Built [ 38.359s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.139s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 37.621s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.139s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.631s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 78.562s] datafusion-physical-plan Building datafusion-proto v54.0.0 (current) Built [ 60.139s] (current) Parsing datafusion-proto v54.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.0.0 (baseline) Built [ 58.240s] (baseline) Parsing datafusion-proto v54.0.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.238s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method try_into_projection_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/37ab8be13065e117d97bf800e9e00efed983803e/datafusion/proto/src/physical_plan/mod.rs:734 method try_from_projection_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/37ab8be13065e117d97bf800e9e00efed983803e/datafusion/proto/src/physical_plan/mod.rs:2433 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 120.312s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
