adriangb commented on code in PR #23495:
URL: https://github.com/apache/datafusion/pull/23495#discussion_r3597518836
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -731,36 +747,6 @@ pub trait PhysicalPlanNodeExt: Sized {
)))
}
- fn try_into_projection_physical_plan(
Review Comment:
Fair point. Yes, these will break downstream builds. I don't see any way
around it since we want to remove public methods exposing implementation
details these functions rely on for at least some plans. We could leave most of
them around as dead / deprecated, I'll see what I can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
