gene-bordegaray commented on code in PR #23484:
URL: https://github.com/apache/datafusion/pull/23484#discussion_r3570357099
##########
datafusion/core/tests/physical_optimizer/enforce_distribution.rs:
##########
@@ -870,6 +870,298 @@ fn
range_inner_hash_join_rehashes_incompatible_range_partitioning() -> Result<()
Ok(())
}
+#[test]
+fn range_right_hash_join_reuses_range_partitioning() -> Result<()> {
Review Comment:
note before I do full review: we are doing most end to end testing in
`range_partitioning.slt` rather than the unit to ensure behavior works across
all distribution rules. Our split has been 1-2 unit tests for smoke or hard to
replicate scenarios in slt, then the bulk in the slt test. Thank you 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
