timsaucer commented on PR #23418: URL: https://github.com/apache/datafusion/pull/23418#issuecomment-4984826743
The advantage of your approach here is that it's a much smaller PR to achieve the same end goal. The PR I had suggested was because I was also trying to address the existing self-described hack where we aren't properly passing around the context. Since I haven't been able to get a review on my other approach really, I suggest we go forward with your more tactical approach. I did put up a PR targeting your branch at https://github.com/apache/datafusion/pull/23622 that contains a test that fails without the additional corrections in the PR. My branch would also fail this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
