gabotechs commented on PR #23418: URL: https://github.com/apache/datafusion/pull/23418#issuecomment-4985051172
👍 Sounds good. Even if there's a comment in the code stating it's not ideal, `ExecutionProps` does not sound that bad for transporting the `subquery_indexes` and `subquery_results`, that's the main reason for me to think that is not that hacky. For a better way of transporting these fields, it would be nice to have had @neilconway's input in the original PR (https://github.com/apache/datafusion/pull/22340), as I'm pretty unfamiliar with those. I guess this PR does not close the door to cleaning that up if there's something to be cleaned up, so going with it might be more conservative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
