github-actions[bot] commented on PR #23722: URL: https://github.com/apache/datafusion/pull/23722#issuecomment-5028889861
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-expr v54.0.0 (current) Built [ 35.552s] (current) Parsing datafusion-physical-expr v54.0.0 (current) Parsed [ 0.054s] (current) Building datafusion-physical-expr v54.0.0 (baseline) Built [ 30.145s] (baseline) Parsing datafusion-physical-expr v54.0.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-physical-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.539s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_expr::create_physical_sort_exprs now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:211 datafusion_physical_expr::planner::create_physical_expr now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:114 datafusion_physical_expr::create_physical_expr now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:114 datafusion_physical_expr::create_physical_partitioning now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:223 datafusion_physical_expr::planner::create_physical_exprs now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:575 datafusion_physical_expr::create_physical_exprs now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:575 datafusion_physical_expr::create_physical_sort_expr now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:199 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_expr::aggregate::LoweredAggregateBuilder::new takes 5 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/8a43071b67a4717025d38da73af2e81c0622de98/datafusion/physical-expr/src/aggregate.rs:440, but now takes 4 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/aggregate.rs:434 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 67.877s] datafusion-physical-expr Building datafusion-sqllogictest v54.0.0 (current) Built [ 200.385s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.025s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 205.902s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.117s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 409.693s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
