github-actions[bot] commented on PR #23723: URL: https://github.com/apache/datafusion/pull/23723#issuecomment-5029105051
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions-table v54.0.0 (current) Built [ 45.812s] (current) Parsing datafusion-functions-table v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-functions-table v54.0.0 (baseline) Built [ 44.819s] (baseline) Parsing datafusion-functions-table v54.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-functions-table v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.090s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: SeriesValue::advance now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/functions-table/src/generate_series.rs:88 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 92.433s] datafusion-functions-table Building datafusion-sqllogictest v54.0.0 (current) Built [ 181.360s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 181.256s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.086s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 365.331s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
