alamb commented on code in PR #11734: URL: https://github.com/apache/datafusion/pull/11734#discussion_r1714392608
########## datafusion/sqllogictest/test_files/aggregate_skip_partial.slt: ########## @@ -267,6 +282,20 @@ FROM aggregate_test_100_null GROUP BY c2 ORDER BY c2; 4 11 14 5 8 7 +# Test avg for tinyint / float Review Comment: The idea was that `AVG` the accumulator is already tested elsewhere -- this test is only to exercise the partial aggregate skipping logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org