Ruchirtripathi commented on code in PR #24029:
URL: https://github.com/apache/datafusion/pull/24029#discussion_r3713958258
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -1781,6 +1785,65 @@ mod tests {
Ok(())
}
+ #[test]
+ fn ordered_aggregate_nested_nullability_mismatch_issue_24022() ->
Result<()> {
Review Comment:
Thanks for the detailed review! That makes sense. I'll add an equivalent
regression for `DistinctArrayAggAccumulator::evaluate` using a declared struct
type with a nullable field and runtime values whose struct field is
non-nullable. I'll assert both the exact resulting list type and the values to
cover the nested nullability preservation in the DISTINCT decoding path, then
update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
