Ruchirtripathi commented on PR #24029:
URL: https://github.com/apache/datafusion/pull/24029#issuecomment-5181593155
Hey! @kosiew Just pushed the latest changes.
I've added the missing nested-nullability regression test for the
DISTINCT accumulator just like you asked. I set up a declared nullable struct
field,
fed it a runtime non-nullable struct, and asserted that both the resulting
list type and the exact inner values correctly preserved the declared
nullability. (I also went ahead and updated the ordered aggregate test to
assert on the exact values as well, just to be thorough!)
As for the list constructor regressions for `new_list`,
`new_list_from_iter`, and `new_large_list`, those were actually included in my
previous
commit inside `scalar/mod.rs`, so we should be fully covered there.
Could you take a quick look and let me know if everything looks good to
go now? Thanks again for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
