alamb commented on PR #23975:
URL: https://github.com/apache/datafusion/pull/23975#issuecomment-5184285368
> @alamb I imagine you are referring to #23772. Unless I misinterpreted the
intentions there, I see that's focusing on performance benchmarks, while this
PR focuses on planning-time statistics vs execution-time metrics statistical
divergence.
> I've tried several things already for shipping a tool that can qualify
improvements to DataFusion stats system:
> As there's really not any precedence about what I'm trying to do here, and
it does not quite fit neither in the existing benchmark infrastructure or the
current integration tests, I preferred to ship something as isolated as
possible, so that:
>
> * It does not get in the way of normal benchmarks with additional
(potentially unrelated) code
> * We can easily nuke it if we don't find it useful without touching any
other pre-existing files.
Fair enough.
Another thing we could do potentially is to add some sort of mode to the
benchmark runner ("stats verification mode" perhaps?) that runs the query and
then verifies that the actual metrics match the statistics 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
