alamb opened a new pull request, #24118: URL: https://github.com/apache/datafusion/pull/24118
## Which issue does this PR close? - N/A (documentation only) ## Rationale for this change The `WindowFn` enum in `datafusion-physical-expr` has no documentation, and its `Builtin` variant name is misleading: it actually holds any "standard" window function (such as `lead`, `lag`, `row_number`, or `rank`), including user-defined window functions, while the `Aggregate` variant holds an aggregate function (such as `avg` or `sum`) used as a window function. This PR documents that distinction so readers don't have to trace the constructors to figure it out. ## What changes are included in this PR? Doc comments on `WindowFn` and its two variants, including links to the `WindowExpr` implementations that create each variant. ## Are these changes tested? Covered by CI doc checks; no behavior change. Verified locally with `RUSTDOCFLAGS="-D warnings" cargo doc -p datafusion-physical-expr --no-deps` and `cargo clippy`. ## Are there any user-facing changes? Improved API documentation only; no code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
