alamb commented on code in PR #24118:
URL: https://github.com/apache/datafusion/pull/24118#discussion_r3723556015
##########
datafusion/physical-expr/src/window/window_expr.rs:
##########
@@ -602,9 +602,15 @@ pub(crate) fn get_orderby_values(order_by_columns:
Vec<SortColumn>) -> Vec<Array
order_by_columns.into_iter().map(|s| s.values).collect()
}
+/// State for incrementally evaluating a window function
+/// within a partition, created by [`WindowExpr::create_window_fn`].
#[derive(Debug)]
pub enum WindowFn {
Review Comment:
This struct is not technically pub as it is in a `mod` (not `pub mod),
though it somehow appears in the WindowExpr trait 🤷
It might be nice to fix the naming but I think for now just documenting it
is helpful
https://docs.rs/datafusion/latest/datafusion/physical_expr/window/trait.WindowExpr.html#tymethod.create_window_fn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
