joroKr21 commented on code in PR #11977:
URL: https://github.com/apache/datafusion/pull/11977#discussion_r1717992638
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -2179,6 +2179,7 @@ mod tests {
.map(|order_by_expr| {
let ordering_req = order_by_expr.unwrap_or_default();
AggregateExprBuilder::new(array_agg_udaf(),
vec![Arc::clone(col_a)])
+ .alias("a")
Review Comment:
Do we really need it? Is there a situation where we would not provide the
alias to the physical expression?
I made this change because the alias generated previously was incorrect (it
didn't use the arguments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
