joroKr21 commented on code in PR #11977:
URL: https://github.com/apache/datafusion/pull/11977#discussion_r1718539993
##########
datafusion/expr/src/expr.rs:
##########
@@ -2386,263 +2386,13 @@ fn fmt_function(
write!(f, "{}({}{})", fun, distinct_str, args.join(", "))
}
-pub fn create_function_physical_name(
- fun: &str,
- distinct: bool,
- args: &[Expr],
- order_by: Option<&Vec<Expr>>,
-) -> Result<String> {
- let names: Vec<String> = args
- .iter()
- .map(|e| create_physical_name(e, false))
- .collect::<Result<_>>()?;
-
- let distinct_str = match distinct {
- true => "DISTINCT ",
- false => "",
- };
-
- let phys_name = format!("{}({}{})", fun, distinct_str, names.join(","));
-
- Ok(order_by
- .map(|order_by| format!("{} ORDER BY [{}]", phys_name,
expr_vec_fmt!(order_by)))
- .unwrap_or(phys_name))
-}
-
-pub fn physical_name(e: &Expr) -> Result<String> {
- create_physical_name(e, true)
-}
-
-fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
Review Comment:
@viirya this was the flag, I remembered it incorrectly: `is_first_expr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
