alamb commented on code in PR #12032:
URL: https://github.com/apache/datafusion/pull/12032#discussion_r1719777458
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -149,7 +149,7 @@ where
output_type,
map: hashbrown::raw::RawTable::with_capacity(INITIAL_MAP_CAPACITY),
map_size: 0,
- builder: GenericByteViewBuilder::new().with_block_size(2 * 1024 *
1024),
+ builder: GenericByteViewBuilder::new(),
Review Comment:
@XiangpengHao I would appreciate your help with this change
In https://github.com/apache/datafusion/pull/11862 you set this to
`with_fixed_block_size`:
https://github.com/apache/datafusion/pull/11862/files#diff-0007996e12eb1b2e63363974424f13330f85a7fc48e0c55381f8a30a0f372931R405
However, since then you have added the dynamic growth size in
https://github.com/apache/arrow-rs/pull/6136 which seems like it would be
better
Would it be possible for you to run your benchmarks again to make sure this
doesn't cause regressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
