alamb commented on code in PR #12032:
URL: https://github.com/apache/datafusion/pull/12032#discussion_r1719884911
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -149,7 +149,7 @@ where
output_type,
map: hashbrown::raw::RawTable::with_capacity(INITIAL_MAP_CAPACITY),
map_size: 0,
- builder: GenericByteViewBuilder::new().with_block_size(2 * 1024 *
1024),
+ builder: GenericByteViewBuilder::new(),
Review Comment:
Awesome -- thank you for checking. I like how the code doesn't have magic
constants in it anymore too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
